Skip to content

Create lz78.py #11842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Create lz78.py #11842

wants to merge 11 commits into from

Conversation

Ahmed99125
Copy link

@Ahmed99125 Ahmed99125 commented Oct 7, 2024 •
edited
Loading

Describe your change:

Added LZ78 compression algorithm.
Fixes #11837

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Ahmed99125 and others added 3 commits October 7, 2024 06:49
@Ahmed99125
Create lz78.py
8269a63 
added lz78 compression algorithm
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7a2d33e 
for more information, see https://pre-commit.ci
@Ahmed99125
Update lz78.py
b544f10 
fixed some errors
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 7, 2024
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 7, 2024
@Ahmed99125
Update lz78.py
c307a60 
fixed errors
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 7, 2024
cclauss
cclauss reviewed Oct 7, 2024
View reviewed changes
cclauss
cclauss reviewed Oct 7, 2024
View reviewed changes
Ahmed99125 and others added 2 commits October 7, 2024 14:44
@Ahmed99125 @cclauss
Update compression/lz78.py
d85fde2 
Co-authored-by: Christian Clauss <[email protected]>
@Ahmed99125
Update lz78.py
c7d1ece 
added more tests
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 7, 2024
@Ahmed99125
Update lz78.py
34fe6bf 
fixed some errors
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 7, 2024
@Ahmed99125
Copy link
Author

@cclauss please review

cclauss
cclauss reviewed Oct 8, 2024
View reviewed changes
Ahmed99125 and others added 2 commits October 8, 2024 18:39
@Ahmed99125
Update lz78.py
676da50 
adding error handling and more tests
@Ahmed99125 @cclauss
Update compression/lz78.py
c27a91e 
Co-authored-by: Christian Clauss <[email protected]>
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 8, 2024
@Ahmed99125
Update lz78.py
bab8e63 
fixed a bug in a test case
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 8, 2024
@Ahmed99125
Copy link
Author

@cclauss raised an exception when the input is not string and added the for loop in the last test case.
Please review.

@Ahmed99125
Copy link
Author

Can anyone review my work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LZ78 compression algorithm is missing
2 participants
@Ahmed99125 @cclauss